Skip to content

chore(examples/37_css-stylex): use @stylexjs/unplugin#1983

Merged
dai-shi merged 2 commits into
wakujs:mainfrom
Master-Hash:stylex-unplugin
Mar 16, 2026
Merged

chore(examples/37_css-stylex): use @stylexjs/unplugin#1983
dai-shi merged 2 commits into
wakujs:mainfrom
Master-Hash:stylex-unplugin

Conversation

@Master-Hash
Copy link
Copy Markdown
Contributor

Vite 8 use lightningcss instead of postcss, so original approach will break. This PR is the preparation.

This approach is also used by StyleX upstream: https://github.com/facebook/stylex/tree/main/examples/example-waku

Split from #1982

…bel + `@stylexjs/postcss-plugin`

Vite 8 use lightningcss instead of postcss, so original approach will break.
This PR is the preparation.
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
waku Ignored Ignored Preview Mar 13, 2026 6:05am

Request Review

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Mar 13, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 13, 2026

Open in StackBlitz

npm i https://pkg.pr.new/waku@1983

commit: 10d95ee

Copy link
Copy Markdown
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Would anyone else like to review?

Comment thread examples/37_css-stylex/src/pages/index.tsx Outdated
Copy link
Copy Markdown
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-shi dai-shi merged commit 53a22eb into wakujs:main Mar 16, 2026
28 checks passed
@mellyeliu
Copy link
Copy Markdown

cool stuff :D

@Master-Hash Master-Hash deleted the stylex-unplugin branch March 19, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants